Skip to content

wxwidgets: fix build#165630

Merged
AndersonTorres merged 1 commit intoNixOS:masterfrom
willcohen:wxwidgets
Mar 26, 2022
Merged

wxwidgets: fix build#165630
AndersonTorres merged 1 commit intoNixOS:masterfrom
willcohen:wxwidgets

Conversation

@willcohen
Copy link
Contributor

@willcohen willcohen commented Mar 24, 2022 •
edited
Loading

Description of changes
Things done

Reverse incorrect assert from #163335, to fix #165444. See discussion from https://github.com/NixOS/nixpkgs/pull/150908/files#r770658765, where this came up before.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

knl
knl reviewed Mar 24, 2022
View reviewed changes
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Mar 24, 2022
@ofborg ofborg bot requested review from AndersonTorres and tfmoraes March 24, 2022 15:05
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 24, 2022
@willcohen
Copy link
Contributor Author

willcohen commented Mar 24, 2022 •
edited
Loading

Result of nixpkgs-review pr 165630 run on x86_64-darwin 1

Edit: a little weird to me, but I guess that's because nothing on darwin currently uses it, as noted above?

@knl
Copy link
Contributor

knl commented Mar 24, 2022

Yes, all uses are broken by themselves. For example, kicad is broken because of wxpython and poedit because of lucene++ :(
I'm working on fixing kicad at least.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Mar 24, 2022
@willcohen
Copy link
Contributor Author

willcohen commented Mar 24, 2022

Result of nixpkgs-review pr 165630 run on x86_64-linux 1

11 packages built:
  • grass
  • kicad-small
  • kicad-unstable-small
  • playonlinux
  • poedit
  • python310Packages.kicad
  • python310Packages.wxPython_4_1
  • python39Packages.kicad
  • python39Packages.wxPython_4_1
  • qgis
  • qgis-ltr

@willcohen
Copy link
Contributor Author

willcohen commented Mar 24, 2022

Ok, back in business. With this PR everything's building again on linux.

@AndersonTorres AndersonTorres merged commit 5302fbb into NixOS:master Mar 26, 2022
@willcohen
Copy link
Contributor Author

willcohen commented Mar 26, 2022

Thanks @AndersonTorres!

@willcohen willcohen deleted the wxwidgets branch March 26, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

2 more reviewers

@tfmoraes tfmoraes tfmoraes approved these changes

@knl knl knl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gtk 3 wxGTX 3.1 programs POEdit, Kicad, and QGIS fail assertion '(withWebKit -> (stdenv).isDarwin)'

4 participants

@willcohen @knl @tfmoraes @AndersonTorres